All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Gergel <fc@yauza.ru>
To: linux-kernel@vger.kernel.org
Cc: Brendan Burns <bburns@genet.cs.umass.edu>
Subject: Re: MINOR(inode->i_rdev) vs. minor(inode->i_rdev)
Date: Wed, 9 Jan 2002 22:55:17 +0300	[thread overview]
Message-ID: <20020109225517.182c8e24.fc@yauza.ru> (raw)
In-Reply-To: <1010604024.2904.0.camel@epiphany>
In-Reply-To: <1010604024.2904.0.camel@epiphany>

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On 09 Jan 2002 14:20:23 -0500
Brendan Burns <bburns@eksl.cs.umass.edu> wrote:

> Hello,
Hello!

> In the process of compiling ALSA for my new 2.5.2pre10 kernel I noticed
> that MINOR(inode->i_rdev) causes compile errors and should be replaced
> with minor(inode->i_rdev) Looking at a number of the OSS sound drivers
> in the kernel I noticed that they to would not compile in 2.5.2pre10 (eg
> Turtle Beach Pinnacle)  I fixed all of these modules and a patch is
> attached.  However, looking further I noticed that there were similar
> problems in a number of other drivers.  Before I undertook cleaning all
> of them I thought I would check in and make sure I was doing the right
> thing.  Namely that every instance of MINOR(inode->i_rdev) or
> MINOR(i_rdev) should be replaced with minor(inode->i_rdev) or
> minor(i_rdev).

I've contributed patch for emu10k1, because tests after 'MINOR' replacement successed. You're on the right way.

Regards.

-- 
Nikita Gergel					System Administrator
Moscow, Russia					YAUZA-Telecom

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2002-01-09 19:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-09 19:20 MINOR(inode->i_rdev) vs. minor(inode->i_rdev) Brendan Burns
2002-01-09 19:55 ` Nikita Gergel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020109225517.182c8e24.fc@yauza.ru \
    --to=fc@yauza.ru \
    --cc=bburns@genet.cs.umass.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.