All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Myers <ncm-nospam@cantrip.org>
To: linux-kernel@vger.kernel.org
Cc: axboe@suse.de, davem@redhat.com
Subject: Re: bad patch in aic7xxx_linux.c
Date: Thu, 10 Jan 2002 07:42:40 +0000	[thread overview]
Message-ID: <20020110074240.B25480@cantrip.org> (raw)
In-Reply-To: <20020109090628.A18526@cantrip.org> <20020109.012046.21928803.davem@redhat.com>
In-Reply-To: <20020109.012046.21928803.davem@redhat.com>; from davem@redhat.com on Wed, Jan 09, 2002 at 01:20:46AM -0800

On Wed, Jan 09, 2002 at 01:20:46AM -0800, David S. Miller wrote:
> From: Nathan Myers <ncm-nospam@cantrip.org>
>>    In patch-2.4.18-pre2, a nonsensical change was made in 
>>    linux/drivers/scsi/aic7xxx/aic7xxx_linux.c .  While apparently 
>>    harmless, it suggests to me that you had intended to fold in an 
>>    entirely different patch, and "missed".
>    
> Missed?  That patch fixes a lethal bug.

Indeed, I missed that the value was also passed to ahc_linux_map_seg()
before being clobbered in the next statement.  
 
>    I don't find a current maintainer for aic7xxx listed in MAINTAINERS.
> 
> It's listed in the aic7xxx sources, but the fix in question came to
> Marcelo via Jens Axboe.

One can guess, but there are no addresses for anyone noted there later 
than 1999.  In particular, Justin's address isn't listed.

I am interested in hotplugged aic7xxx (1480 CardBus).  I will be posting 
an Oops shortly related to that, unless somebody tells me not to bother.  

Nathan Myers
ncm at cantrip dot org

  reply	other threads:[~2002-01-10  7:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-09  9:06 bad patch in aic7xxx_linux.c Nathan Myers
2002-01-09  9:20 ` David S. Miller
2002-01-10  7:42   ` Nathan Myers [this message]
2002-01-10 17:59     ` Justin T. Gibbs
2002-01-11  2:24       ` David S. Miller
2002-01-09 16:22 ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020110074240.B25480@cantrip.org \
    --to=ncm-nospam@cantrip.org \
    --cc=axboe@suse.de \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.