From: Jens Axboe <axboe@suse.de>
To: Peter Osterlund <petero2@telia.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5: I/O errors ignored in __scsi_end_request
Date: Mon, 14 Jan 2002 07:43:52 +0100 [thread overview]
Message-ID: <20020114074352.C13929@suse.de> (raw)
In-Reply-To: <m2pu4euogh.fsf@ppro.localdomain>
In-Reply-To: <m2pu4euogh.fsf@ppro.localdomain>
On Sun, Jan 13 2002, Peter Osterlund wrote:
> I/O errors in scsi drivers are being silently ignored in the
> __scsi_end_request function in scsi_lib.c. This patch seems obvious
> enough to me. (And it does work, at least for the packet writing
> module.)
>
> --- linux/drivers/scsi/scsi_lib.c.old Sun Jan 13 18:40:44 2002
> +++ linux/drivers/scsi/scsi_lib.c Sun Jan 13 13:45:03 2002
> @@ -365,7 +365,7 @@
> * If there are blocks left over at the end, set up the command
> * to queue the remainder of them.
> */
> - if (end_that_request_first(req, 1, sectors)) {
> + if (end_that_request_first(req, uptodate, sectors)) {
> if (!requeue)
> return SCpnt;
Irk, what a silly. Thanks, patch is obviously correct.
--
Jens Axboe
prev parent reply other threads:[~2002-01-14 6:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-13 17:53 2.5: I/O errors ignored in __scsi_end_request Peter Osterlund
2002-01-14 6:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020114074352.C13929@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.