All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Jaegermann <michal@harddata.com>
To: Roland Dreier <roland@digitalvampire.org>
Cc: torvalds@transmeta.com, marcelo@conectiva.com.br,
	alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix two bugs in lib/vsprintf.c
Date: Tue, 15 Jan 2002 17:20:10 -0700	[thread overview]
Message-ID: <20020115172010.A26769@mail.harddata.com> (raw)
In-Reply-To: <87advgrmnh.fsf@love-shack.home.digitalvampire.org>
In-Reply-To: <87advgrmnh.fsf@love-shack.home.digitalvampire.org>; from roland@digitalvampire.org on Tue, Jan 15, 2002 at 01:25:38AM -0800

On Tue, Jan 15, 2002 at 01:25:38AM -0800, Roland Dreier wrote:
> The below patch fixes two bugs in lib/vsprintf.c's implementation of
> vsscanf().

If we are looking at these things I have some gnawing suspicions
that a constant 0xFFFFFFFFUL at line 489 of lib/vsprintf.c
in this function:

    int vsprintf(char *buf, const char *fmt, va_list args)
    {
            return vsnprintf(buf, 0xFFFFFFFFUL, fmt, args);
    }

was really meant to be (size_t)(-1).  It is not the same if a platform
is not 32 bits.  Roland, what do you think?

  Michal

  reply	other threads:[~2002-01-16  0:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-15  9:25 [PATCH] fix two bugs in lib/vsprintf.c Roland Dreier
2002-01-16  0:20 ` Michal Jaegermann [this message]
2002-01-16  0:54   ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020115172010.A26769@mail.harddata.com \
    --to=michal@harddata.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=roland@digitalvampire.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.