From: "Tim Pepper" <tpepper@vato.org>
To: Andries.Brouwer@cwi.nl
Cc: Matt_Domsch@dell.com, linux-kernel@vger.kernel.org
Subject: Re: BLKGETSIZE64 (bytes or sectors?)
Date: Thu, 17 Jan 2002 16:21:40 -0800 [thread overview]
Message-ID: <20020117162140.F11402@vato.org> (raw)
In-Reply-To: <UTC200201172348.XAA420548.aeb@cwi.nl>
In-Reply-To: <UTC200201172348.XAA420548.aeb@cwi.nl>; from Andries.Brouwer@cwi.nl on Thu, Jan 17, 2002 at 11:48:16PM +0000
On Thu 17 Jan at 23:48:16 +0000 Andries.Brouwer@cwi.nl done said:
> Matt_Domsch@dell.com wrote, and he is right:
>
> Yes, in bytes. blkpg.c has to be fixed.
> Several people submitted patches. Sooner or later I suppose
> this will be fixed.
>
>--8< snip-----------
>
> So, indeed, we have already multiplied by hardsect_size, struct gendisk
> uses sectors of size 512, independent of the hardware, and we must not
> again multiply by hardsect_size.
Doh. It's obviously much cleaner and more efficient that way.
Have any of the other patch submitters added a comment to note this in
include/linux/genhd.h? hd_struct doesn't have any mention of start_sect
and nr_sect being stored in sectors of 512bytes. But maybe that's just
to weed out fools like me.
--
*********************************************************
* tpepper@vato dot org * Venimus, Vidimus, *
* http://www.vato.org/~tpepper * Dolavimus *
*********************************************************
next prev parent reply other threads:[~2002-01-18 0:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-17 23:48 BLKGETSIZE64 (bytes or sectors?) Andries.Brouwer
2002-01-18 0:21 ` Tim Pepper [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-01-17 22:34 Matt_Domsch
2002-01-17 22:46 ` Tim Pepper
2002-01-17 20:28 Matt Domsch
2002-01-17 21:12 ` Tim Pepper
2002-01-17 22:47 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020117162140.F11402@vato.org \
--to=tpepper@vato.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=Matt_Domsch@dell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.