From: Dave Jones <davej@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: martin.macok@underground.cz, linux-kernel@vger.kernel.org
Subject: Re: [andrewg@tasmail.com: remote memory reading through tcp/icmp]
Date: Mon, 21 Jan 2002 03:12:11 +0100 [thread overview]
Message-ID: <20020121031211.B29830@suse.de> (raw)
In-Reply-To: <20020121015209.A26413@sarah.kolej.mff.cuni.cz> <20020120.175204.18636524.davem@redhat.com>
In-Reply-To: <20020120.175204.18636524.davem@redhat.com>; from davem@redhat.com on Sun, Jan 20, 2002 at 05:52:04PM -0800
On Sun, Jan 20, 2002 at 05:52:04PM -0800, David S. Miller wrote:
> Pretty simple to fix, from Andi Kleen:
>
> --- linux-work/net/ipv4/icmp.c-o Tue Jan 15 11:05:17 2002
> +++ linux-work/net/ipv4/icmp.c Sun Jan 20 23:31:29 2002
> @@ -495,7 +495,7 @@
> icmp_param.data.icmph.checksum=0;
> icmp_param.csum=0;
> icmp_param.skb=skb_in;
> - icmp_param.offset=skb_in->nh.raw - skb_in->data;
> + icmp_param.offset=skb_in->data - skb_in->nh.raw;
With this fix, I'm seeing lots of really strange things happen.
When eth0 comes up, the box slows down to a crawl.
5 minutes later when it gets to starting NIS, the
broadcast address is bombed with portmap connections.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-01-21 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-21 0:52 [andrewg@tasmail.com: remote memory reading through tcp/icmp] Martin Mačok
2002-01-21 1:52 ` David S. Miller
2002-01-21 2:12 ` Dave Jones [this message]
2002-01-21 2:43 ` David S. Miller
2002-01-21 14:14 ` Russell King
2002-01-21 16:32 ` Dave Jones
2002-01-21 14:44 ` Russell King
2002-01-23 15:18 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020121031211.B29830@suse.de \
--to=davej@suse.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.macok@underground.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.