From: Jens Axboe <axboe@suse.de>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make ide-scsi compile in 2.5
Date: Sun, 27 Jan 2002 11:49:43 +0100 [thread overview]
Message-ID: <20020127114942.A4140@suse.de> (raw)
In-Reply-To: <20020127024631.A28936@wotan.suse.de>
In-Reply-To: <20020127024631.A28936@wotan.suse.de>
On Sun, Jan 27 2002, Andi Kleen wrote:
>
> ide-scsi doesn't compile currently in 2.5.x. This patch fixes it in a
> rather hackish way by adding some kmap_atomic()s. It would be
> probably better to kmap earlier in process context in the request
> function instead, but I leave this to the people who know more
> about IDE/block layer than me (but apparently not compile ide-scsi..)
axboe@burns:~/src/linux> make drivers/scsi/ide-scsi.o
gcc -D__KERNEL__ -I/home/axboe/src/linux/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i686 -c -o drivers/scsi/ide-scsi.o drivers/scsi/ide-scsi.c
axboe@burns:~/src/linux>
Works for me, what didn't compile?
Are you sure that you aren't hitting the sg address change? AFAICS,
there should not be a need for highmem mapping here. Requests coming out
of the block layer for /dev/scd* should be bounced for you, and sg
doesn't pass on highmem pages iirc.
Puzzled...
--
Jens Axboe
next prev parent reply other threads:[~2002-01-27 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-27 1:46 [PATCH] Make ide-scsi compile in 2.5 Andi Kleen
2002-01-27 10:49 ` Jens Axboe [this message]
2002-01-27 15:51 ` Skip Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020127114942.A4140@suse.de \
--to=axboe@suse.de \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.