Re: [PATCH] sd-many for 2.4.18-pre7 (uses devfs)

[Jens Axboe <axboe@suse.de>]

On Mon, Jan 28 2002, Richard Gooch wrote:
> Jens Axboe writes:
> > On Sun, Jan 27 2002, Richard Gooch wrote:
> > >   Hi, all. Appended is my sd-many patch. It supports up to 2080
> > > SD's. This patch is against 2.4.18-pre7, and is essentially the same
> > > as earlier versions of this patch, just compensating for kernel drift.
> > 
> > Could you please at least try to follow the style in sd? To me, this
> > alone is reason enough why the patch should not be applied.
> 
> ??? I *have* followed the style. Or at least I've tried to. Where did
> I not?

Are you serious?! You use

	if (condition) do_something

you use

#ifdef something
#  define something_else
#endif

Your choice of style isn't even consistent throughout the patch...
Granted, SCSI isn't the most consistently styled stuff out there, but
lets not make it worse.

-- 
Jens Axboe