From: Pete Wyckoff <pw@osc.edu>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] typo in i386 machine check code
Date: Tue, 29 Jan 2002 13:25:32 -0500 [thread overview]
Message-ID: <20020129132532.B10960@osc.edu> (raw)
Our old PIII Xeons are dying, as shown by more frequent panics
due to bad hardware:
kernel: CPU 3: Machine Check Exception: 0000000000000007
kernel: Bank 0: b678600022000800 at 3678600022000800
The part after the "at" is supposed to be the memory address which
was being accessed when the fault was detected. Instead the code
prints out the status field again (with the high bit removed for
no apparent reason).
Patch is against 2.5.2.
-- Pete
--- linux/arch/i386/kernel/bluesmoke.c.orig Tue Jan 29 12:04:46 2002
+++ linux/arch/i386/kernel/bluesmoke.c Tue Jan 29 12:04:48 2002
@@ -40,21 +40,21 @@ static void intel_machine_check(struct p
high&=~(1<<31);
if(high&(1<<27))
{
rdmsr(MSR_IA32_MC0_MISC+i*4, alow, ahigh);
printk("[%08x%08x]", alow, ahigh);
}
if(high&(1<<26))
{
rdmsr(MSR_IA32_MC0_ADDR+i*4, alow, ahigh);
printk(" at %08x%08x",
- high, low);
+ ahigh, alow);
}
printk("\n");
/* Clear it */
wrmsr(MSR_IA32_MC0_STATUS+i*4, 0UL, 0UL);
/* Serialize */
wmb();
}
}
if(recover&2)
next reply other threads:[~2002-01-29 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-29 18:25 Pete Wyckoff [this message]
2002-01-29 18:37 ` [patch] typo in i386 machine check code Dave Jones
2002-01-29 19:18 ` Alan Cox
2002-01-29 19:23 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020129132532.B10960@osc.edu \
--to=pw@osc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.