All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <garzik@havoc.gtf.org>
To: Andi Kleen <ak@muc.de>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, davej@suse.de
Subject: Re: [PATCH] Fix rocket port driver
Date: Wed, 30 Jan 2002 20:16:40 -0500	[thread overview]
Message-ID: <20020130201640.A18730@havoc.gtf.org> (raw)
In-Reply-To: <20020131003130.A1413@averell>
In-Reply-To: <20020131003130.A1413@averell>; from ak@muc.de on Thu, Jan 31, 2002 at 12:31:30AM +0100

On Thu, Jan 31, 2002 at 12:31:30AM +0100, Andi Kleen wrote:

Cool.


> @@ -2042,6 +2046,10 @@
>  			PCI_DEVICE_ID_RP8M, i, &bus, &device_fn)) 
>  			if(register_PCI(count+boards_found, bus, device_fn))
>  				count++;
> +		if(!pcibios_find_device(PCI_VENDOR_ID_RP,
> +			0x8, i, &bus, &device_fn)) 
> +			if(register_PCI(count+boards_found, bus, device_fn))
> +				count++;	

Would it be possible to beg and plead and convince you to convert this
driver to the new PCI API?

It hasn't been touched in ages AFAICS, and both 2.4 as well as 2.5 would
greatly benefit from such a [tested] change.

	Jeff




  reply	other threads:[~2002-01-31  1:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-30 23:31 [PATCH] Fix rocket port driver Andi Kleen
2002-01-31  1:16 ` Jeff Garzik [this message]
2002-01-31  1:24   ` Andi Kleen
2002-01-31  1:25     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020130201640.A18730@havoc.gtf.org \
    --to=garzik@havoc.gtf.org \
    --cc=ak@muc.de \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.