From: Michal Jaegermann <michal@harddata.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Michal Jaegermann <michal@harddata.com>,
linux-kernel@vger.kernel.org,
Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [PATCH] Symbol troubles in 2.4.18pre... kernels
Date: Sun, 3 Feb 2002 20:47:59 -0700 [thread overview]
Message-ID: <20020203204759.A14119@mail.harddata.com> (raw)
In-Reply-To: <20020203171615.A12981@mail.harddata.com> <E16XXIq-0005ml-00@the-village.bc.nu>
In-Reply-To: <E16XXIq-0005ml-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Mon, Feb 04, 2002 at 12:48:12AM +0000
On Mon, Feb 04, 2002 at 12:48:12AM +0000, Alan Cox wrote:
>
> > 'isa_eth_io_copy_and_sum' is defined only for some architectures but
> > assorted modules, like drivers/net/3c503.o and few others, can be
> > configured, say, for Alpha and 'depmod' once again complains about
> > unresolved symbols. I do not think that anybody will really miss that
> > on Alpha but maybe configuring them in should be disallowed?
>
> This is a bug in the Alpha port. Fix the port. Its not ecactly the
> most complex function to implement.
Well, the best I can tell by looking at other implementations and
comparing there is not much to implement and the fix looks like
that:
--- linux-2.4.18p7/include/asm-alpha/io.h~ Sun Feb 3 16:42:17 2002
+++ linux-2.4.18p7/include/asm-alpha/io.h Sun Feb 3 20:35:13 2002
@@ -432,6 +432,8 @@
#define eth_io_copy_and_sum(skb,src,len,unused) \
memcpy_fromio((skb)->data,(src),(len))
+#define isa_eth_io_copy_and_sum(a,b,c,d) eth_copy_and_sum((a),(b),(c),(d))
+
static inline int
check_signature(unsigned long io_addr, const unsigned char *signature,
int length)
But I really have no way to test that on a real, live, hardware.
It compiles. :-)
Michal
prev parent reply other threads:[~2002-02-04 3:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-04 0:16 [PATCH] Symbol troubles in 2.4.18pre... kernels Michal Jaegermann
2002-02-04 0:48 ` Alan Cox
2002-02-04 3:47 ` Michal Jaegermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020203204759.A14119@mail.harddata.com \
--to=michal@harddata.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.