From: David Weinehall <tao@acc.umu.se>
To: "Hanno Böck" <hanno@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Patch for eepro100 to support more cards
Date: Wed, 6 Feb 2002 13:27:27 +0100 [thread overview]
Message-ID: <20020206132727.H1735@khan.acc.umu.se> (raw)
In-Reply-To: <20020201080545Z291604-13996+15441@vger.kernel.org>
In-Reply-To: <20020201080545Z291604-13996+15441@vger.kernel.org>; from hanno@gmx.de on Fri, Feb 01, 2002 at 09:06:26AM +0100
On Fri, Feb 01, 2002 at 09:06:26AM +0100, Hanno Böck wrote:
> This patch adds support for the
> Intel Pro/100 VE
> Network card to the eepro100.c
>
> This card is installed in my notebook (Sony Vaio PCG-GR114MK). Seems to work
> fine.
Nice!
[snip]
> +#ifndef PCI_DEVICE_ID_INTEL_ID1031 // Support for Intel Pro/100
> VE added by Hanno Boeck <hanno@gmx.de>
[snip]
PLEASE put this kind of comments in the changelog or similarly fitting
place instead of in the code. If everyone had their e-mail address
in a comment after every line they added, would be bloated beyond
proportions (some argue that it already is, but let's ignore that for
now...)
Regards: David Weinehall
_ _
// David Weinehall <tao@acc.umu.se> /> Northern lights wander \\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </
next prev parent reply other threads:[~2002-02-06 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-01 8:06 Patch for eepro100 to support more cards Hanno Böck
2002-02-06 12:27 ` David Weinehall [this message]
2002-02-06 14:45 ` Hanno Böck
2002-02-07 17:45 ` Josh Grebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020206132727.H1735@khan.acc.umu.se \
--to=tao@acc.umu.se \
--cc=hanno@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.