From: Dave Jones <davej@suse.de>
To: Brent Cook <busterb@mail.utexas.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Fix for duplicate /proc entries
Date: Wed, 6 Feb 2002 19:11:08 +0100 [thread overview]
Message-ID: <20020206191108.A11277@suse.de> (raw)
In-Reply-To: <20020205213544.J3054-100000@ozma.union.utexas.edu>
In-Reply-To: <20020205213544.J3054-100000@ozma.union.utexas.edu>; from busterb@mail.utexas.edu on Tue, Feb 05, 2002 at 09:52:55PM -0600
On Tue, Feb 05, 2002 at 09:52:55PM -0600, Brent Cook wrote:
> I think that I have found a problem with proc_dir_entry(). It seems to
> allow multiple /proc entries to be created with the same name, without
> returning a NULL pointer. I asked the folks on #kernelnewbies, and they
> said that perhaps this is a feature. In either case, I believe that the
> following patch fixes the issue by checking if a proc entry already exists
> before creating it. This mirrors the behavior of remove_proc_entry, which
> checks for the presense of a proc entry before deleting it.
The only instance I've seen of this happen is the acpi code.
Whilst the patch is good in the sense that it allows things like
/proc/acpi/button to become usable, the correct fix would be
to fix ACPI.
Maybe printk'ing a "tried to create duplicate xxx proc entry"
would be useful, so we at least don't paper over problems and
make them harder to find later.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-02-06 18:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-06 3:52 Fix for duplicate /proc entries Brent Cook
2002-02-06 18:11 ` Dave Jones [this message]
2002-02-07 21:38 ` Brent Cook
2002-02-07 21:45 ` Dave Jones
2002-02-08 16:13 ` Brent Cook
2002-02-08 17:47 ` Mike Fedyk
2002-02-08 17:54 ` Alexander Viro
2002-02-08 18:12 ` Tommy Reynolds
2002-06-14 22:30 ` File permission problem with NFSv3 and 2.5.20-dj4 Brent Cook
2002-06-15 12:23 ` Dave Jones
2002-06-19 17:45 ` Brent Cook
2002-06-19 17:48 ` Dave Jones
2002-06-19 17:52 ` another sched.c error with athlon Kirk Reiser
2002-06-19 18:27 ` Adrian Bunk
2002-04-10 14:02 ` Mouse interrupts: the death knell of a VP6 Brent Cook
2002-04-10 15:23 ` Oleg Drokin
2002-04-10 16:43 ` Brent Cook
2002-04-10 16:49 ` William Park
2002-04-11 6:39 ` john slee
2002-04-10 20:55 ` Oleg Drokin
2002-04-10 17:16 ` John Adams
2002-04-10 17:52 ` Brent Cook
[not found] <Pine.LNX.4.33.0202081203020.29252-100000@coffee.psychology.mcmaster.ca>
2002-02-08 19:26 ` Fix for duplicate /proc entries Brent Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020206191108.A11277@suse.de \
--to=davej@suse.de \
--cc=busterb@mail.utexas.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.