From: Benjamin LaHaise <bcrl@redhat.com>
To: Suparna Bhattacharya <suparna@in.ibm.com>
Cc: linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: patch: aio + bio for raw io
Date: Fri, 8 Feb 2002 17:02:57 -0500 [thread overview]
Message-ID: <20020208170257.A12788@redhat.com> (raw)
In-Reply-To: <20020208025313.A11893@redhat.com> <20020208151009.A1810@in.ibm.com>
In-Reply-To: <20020208151009.A1810@in.ibm.com>; from suparna@in.ibm.com on Fri, Feb 08, 2002 at 03:10:09PM +0530
On Fri, Feb 08, 2002 at 03:10:09PM +0530, Suparna Bhattacharya wrote:
> You chose to add a kvec_cb field to the bio structure rather than use
> bi_private ?
Yup. I'm lazy. Also, the cb struct actually needs 2 pointers, so just
bi_private isn't enough.
> For the raw path, you are OK since you never have to copy data out of
> the kvecs after i/o completion, and unmap_kvec only looks at veclet pages.
> So the fact block can change the offset and len fields in the veclets
> doesn't affect you, but thought I'd mention it as a point of caution
> anyhow ...
Ugh. That sounds like something bio should not be doing. If someone
wants to fix it, such a patch would be much appreciated, otherwise it'll
wait until I'm back in Canada.
-ben
next prev parent reply other threads:[~2002-02-08 22:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-08 7:53 patch: aio + bio for raw io Benjamin LaHaise
2002-02-08 9:40 ` Suparna Bhattacharya
2002-02-08 22:02 ` Benjamin LaHaise [this message]
2002-02-11 18:11 ` Suparna Bhattacharya
2002-02-08 21:07 ` Badari Pulavarty
2002-02-08 21:18 ` arjan
2002-02-08 22:13 ` Benjamin LaHaise
2002-02-08 22:54 ` Linus Torvalds
[not found] ` <200202082254.g18Mspq08299@penguin.transmeta.com>
2002-02-09 0:01 ` Benjamin LaHaise
2002-02-09 0:25 ` Linus Torvalds
2002-02-14 4:46 ` Suparna Bhattacharya
2002-02-11 11:09 ` Jens Axboe
2002-02-11 21:37 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020208170257.A12788@redhat.com \
--to=bcrl@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.