From: Mike Phillips <phillim2@comcast.net>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Linux-Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] New driver 3Com 3C359 Tokenring Velocity XL
Date: Wed, 20 Feb 2002 21:20:22 -0500 [thread overview]
Message-ID: <20020221022022.GA3650@comcast.net> (raw)
In-Reply-To: <3C73CF85.E3DA3943@mandrakesoft.com>
In-Reply-To: <Pine.LNX.4.10.10202181451060.4149-100000@www.linuxtr.net> <3C73CF85.E3DA3943@mandrakesoft.com>
Jeff:
> Comments:
> 1) buggy use of PCI DMA API -- you should use memory returned from
> pci_alloc_consistent, do not directly map memory created by
> alloc_trdev() nor depend on the alignment returned by alloc_trdev()
The driver doesn't map any of the ->priv structure, the comment in the
code is a left over from when it did. The priv strcture just has
pointers to the memory areas (which are kmalloc'ed and mapped).
I should probably change the allocations to pci_alloc_consistent
from their current map_single as well.
All other comments taken on board, will be included in the next
update.
> Overall... good job, it's a readable, clean driver.
>
Thanks, these things do get a little easier each time you do one (esp.
once you've figured out which planet the hardware designers and tech
doc writers live on :)
--
Mike Phillips
Linux Token Ring Project
http://www.linuxtr.net
mailto: mikep@linuxtr.net
prev parent reply other threads:[~2002-02-21 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-18 20:58 [PATCH] New driver 3Com 3C359 Tokenring Velocity XL Mike Phillips
2002-02-20 16:32 ` Jeff Garzik
2002-02-21 2:20 ` Mike Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020221022022.GA3650@comcast.net \
--to=phillim2@comcast.net \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikep@linuxtr.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.