From: Larry McVoy <lm@bitmover.com>
To: Dan Aloni <da-x@gmx.net>
Cc: bert hubert <ahu@ds9a.nl>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH] C exceptions in kernel
Date: Sat, 23 Feb 2002 08:22:11 -0800 [thread overview]
Message-ID: <20020223082211.Z11156@work.bitmover.com> (raw)
In-Reply-To: <1014412325.1074.36.camel@callisto.yi.org> <20020223162100.A1952@outpost.ds9a.nl> <1014480355.1844.16.camel@callisto.yi.org>
In-Reply-To: <1014480355.1844.16.camel@callisto.yi.org>; from da-x@gmx.net on Sat, Feb 23, 2002 at 06:05:48PM +0200
On Sat, Feb 23, 2002 at 06:05:48PM +0200, Dan Aloni wrote:
> But, it CAN be used in *local* driver call branches. Writing a new
> driver? have a lot of local nested calls? Hate goto's? You can use
> exceptions.
Is this really anything other than syntactic sugar? Maybe it's different
in drivers, but I find myself doing the following in user space all the time
#define unless(x) if (!(x)) /* perl/BCPL corrupted me */
function(...)
{
char *foo = 0, *bar = 0;
int locked = 0;
int rc = -1;
if (bad args or something) {
out: if (foo) free(foo);
if (bar) free(bar);
if (locked) unlock();
return (rc);
}
unless (locked = get_the_lock()) goto out;
unless (foo = allocate_foo()) goto out;
unless (bar = allocate_bar()) goto out;
more code....
rc = 0;
goto out;
}
It seems ugly at first but it has some nice attributes:
a) all the cleanup is in one place, for both the error path and the
non-error path. I could put it at the bottom, I like it at the
top because that's where I tend to have the list of things needed
to be cleaned.
b) all the error cases are branches, the normal path is straightline.
c) it's as dense as I can make it.
So how would you do the same thing with exceptions?
--
---
Larry McVoy lm at bitmover.com http://www.bitmover.com/lm
next prev parent reply other threads:[~2002-02-23 16:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-22 21:12 [RFC] [PATCH] C exceptions in kernel Dan Aloni
2002-02-22 21:28 ` Davide Libenzi
2002-02-22 22:10 ` Richard B. Johnson
2002-02-22 22:34 ` David B. Stevens
2002-02-22 22:48 ` Davide Libenzi
2002-02-23 3:37 ` Edgar Toernig
[not found] ` <mailman.1014437101.26721.linux-kernel2news@redhat.com>
2002-02-23 10:11 ` Pete Zaitcev
2002-02-23 12:26 ` Keith Owens
2002-02-23 12:50 ` Pete Zaitcev
2002-02-23 23:07 ` Jes Sorensen
2002-02-23 23:40 ` Keith Owens
2002-02-24 1:02 ` Jes Sorensen
2002-02-24 23:45 ` Richard Gooch
2002-02-23 23:50 ` Bill Huey
2002-02-24 1:31 ` Davide Libenzi
2002-02-24 2:55 ` Bill Huey
2002-02-23 15:13 ` Felix von Leitner
2002-02-23 15:21 ` bert hubert
2002-02-23 16:05 ` Dan Aloni
2002-02-23 16:22 ` Larry McVoy [this message]
2002-02-23 17:00 ` Dan Aloni
2002-02-23 17:52 ` Francois Romieu
2002-02-23 17:07 ` bert hubert
2002-02-23 17:47 ` Alexander Viro
2002-02-23 18:21 ` bert hubert
2002-02-23 18:31 ` Larry McVoy
2002-02-23 18:38 ` bert hubert
2002-02-23 19:12 ` Kurt Ferreira
2002-02-23 23:05 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020223082211.Z11156@work.bitmover.com \
--to=lm@bitmover.com \
--cc=ahu@ds9a.nl \
--cc=da-x@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.