From: Russell King <rmk@arm.linux.org.uk>
To: linux-kernel@vger.kernel.org
Subject: Maze of include files, all producing errors...
Date: Thu, 28 Feb 2002 20:48:26 +0000 [thread overview]
Message-ID: <20020228204826.C13564@flint.arm.linux.org.uk> (raw)
In 2.5.5 (Changeset 1.359.2.3), the highmem.h and pgalloc.h includes were
reversed.
Previous kernels had linux/highmem.h including asm/pgalloc.h. Placing
the architecture cache handling functions worked well in asm/pgalloc.h,
allowing highmem.h to find them; highmem.h uses flush_dcache_page() and
friends in inline functions.
In this changeset, highmem.h no longer includes pgalloc.h, but instead
pgalloc.h includes highmem.h. This, unfortunately, tends to break things
in a major way since the cache functions are no longer available to
highmem.h.
Looking at x86, the (no-op) cache functions live in pgtable.h. However,
trying to put the ARM cache handling into pgtable.h doesn't work because
we need things like PG_arch_1 and struct page. pgtable.h is included by
linux/mm.h before linux/mm.h declares PG_arch_1 and struct page. So
obviously this can't work.
Has anyone encountered this, and has anyone found a magic working
combination?
For now, I'm going to reverse the include changes in this changeset so
things build again.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next reply other threads:[~2002-02-28 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-28 20:48 Russell King [this message]
2002-03-01 0:52 ` Maze of include files, all producing errors Richard Henderson
2002-03-03 22:28 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020228204826.C13564@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.