All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christer Weinigel <wingel@acolyte.hack.org>
To: thibaut@celestix.com
Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NatSemi SCx200 Support
Date: Mon,  4 Mar 2002 02:26:42 +0100 (CET)	[thread overview]
Message-ID: <20020304012642.D56C7F5B@acolyte.hack.org> (raw)
In-Reply-To: <20020304073729.59946087.thibaut@celestix.com> (message from Thibaut Laurent on Mon, 4 Mar 2002 07:37:29 +0800)
In-Reply-To: <Pine.LNX.4.21.0202281244330.2117-100000@freak.distro.conectiva> <20020302160110.11DE1F5B@acolyte.hack.org> <20020304073729.59946087.thibaut@celestix.com>

Thibaut Laurent <thibaut@celestix.com> wrote:
> There's a typo in drivers/i2c/Config.in.
> CONFIG_SCx200_I2C is defined but CONFIG_I2C_SCx200 is tested...
> 
> +      dep_tristate '  NatSemi SCx200 I2C using GPIO pins' CONFIG_SCx200_I2C $CONFIG_ARCH_SCx200 $CONFIG_I2C_ALGOBIT
> +      if [ "$CONFIG_I2C_SCx200" != "n" ]; then
>               ^^^^^^^^^^^^^^^^^
>      this should be CONFIG_SCx200_I2C

You are absolutely correct.  I switched the names around and must have
missed that.  A patch is attached.

Thanks,
 /Christer

diff -ur linux/drivers/i2c/Config.in.orig linux/drivers/i2c/Config.in
--- linux/drivers/i2c/Config.in.orig	Mon Mar  4 01:24:27 2002
+++ linux/drivers/i2c/Config.in	Mon Mar  4 01:25:18 2002
@@ -14,7 +14,7 @@
       dep_tristate '  ELV adapter' CONFIG_I2C_ELV $CONFIG_I2C_ALGOBIT
       dep_tristate '  Velleman K9000 adapter' CONFIG_I2C_VELLEMAN $CONFIG_I2C_ALGOBIT
       dep_tristate '  NatSemi SCx200 I2C using GPIO pins' CONFIG_SCx200_I2C $CONFIG_ARCH_SCx200 $CONFIG_I2C_ALGOBIT
-      if [ "$CONFIG_I2C_SCx200" != "n" ]; then
+      if [ "$CONFIG_SCx200_I2C" != "n" ]; then
          int  '    GPIO pin used for SCL' CONFIG_SCx200_I2C_SCL -1
          int  '    GPIO pin used for SDA' CONFIG_SCx200_I2C_SDA -1
       fi

-- 
"Just how much can I get away with and still go to heaven?"

      reply	other threads:[~2002-03-04  1:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-26  1:52 [PATCH] NatSemi SCx200 Support Christer Weinigel
2002-02-28 15:45 ` Marcelo Tosatti
2002-03-02 16:01   ` Christer Weinigel
2002-03-03 23:37     ` Thibaut Laurent
2002-03-04  1:26       ` Christer Weinigel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020304012642.D56C7F5B@acolyte.hack.org \
    --to=wingel@acolyte.hack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=thibaut@celestix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.