From: Russell King <rmk@arm.linux.org.uk>
To: Ed Vance <EdV@macrolink.com>
Cc: "'Bill Nottingham'" <notting@redhat.com>,
"'linux-serial'" <linux-serial@vger.kernel.org>,
"'linux-kernel'" <linux-kernel@vger.kernel.org>,
"'Alan Cox'" <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] serial.c procfs kudzu - discussion
Date: Fri, 8 Mar 2002 09:49:18 +0000 [thread overview]
Message-ID: <20020308094918.A16358@flint.arm.linux.org.uk> (raw)
In-Reply-To: <11E89240C407D311958800A0C9ACF7D13A76E4@EXCHANGE>
In-Reply-To: <11E89240C407D311958800A0C9ACF7D13A76E4@EXCHANGE>; from EdV@macrolink.com on Thu, Mar 07, 2002 at 03:12:54PM -0800
On Thu, Mar 07, 2002 at 03:12:54PM -0800, Ed Vance wrote:
> This is not the result of a recent change to the serial driver. I don't
> know how far back this bug goes, but I suspect it is as old as the proc
> fs serial support.
I think there are two bugs here that need treating in different ways.
1. Not displaying port statistics for iomem-based ports. This is
probably an oversight when iomem ports were added to the serial
driver.
2. "port:" entry being 0. I don't think we really want to report IO
port or memory addresses here without giving userspace some
indication which we're reporting.
For 2, I'd suggest replacing "port:" with "mem:" for iomem ports, and
changing the serinfo: line to reflect the changed format (this is
probably ignored by kudzu though.)
Does this sound reasonable?
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-03-08 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-07 23:12 [PATCH] serial.c procfs kudzu - discussion Ed Vance
2002-03-08 9:49 ` Russell King [this message]
2002-03-08 10:25 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2002-03-09 0:34 Ed Vance
2002-03-08 19:15 Ed Vance
2002-03-08 18:12 Ed Vance
2002-03-07 22:23 Ed Vance
2002-03-07 22:34 ` Bill Nottingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020308094918.A16358@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=EdV@macrolink.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=notting@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.