From: Andi Kleen <ak@muc.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, ak@muc.de
Subject: Re: __get_user usage in mm/slab.c
Date: Tue, 12 Mar 2002 16:23:16 +0100 [thread overview]
Message-ID: <20020312162316.A3505@averell> (raw)
In-Reply-To: <Pine.LNX.4.21.0203121237070.19747-100000@serv>
In-Reply-To: <Pine.LNX.4.21.0203121237070.19747-100000@serv>
On Tue, Mar 12, 2002 at 12:58:53PM +0100, Roman Zippel wrote:
> Hi,
>
> The way __get_user is currently used in mm/slab.c is not portable. It
> breaks on arch which have seperate user/kernel memory space. It still
> works during boot or from kernel threads, but /proc/slabinfo shows only
> broken entries or if a module creates a slab cache, I got lots of
> warnings.
> We have to at least insert a "set_fs(get_fs())", but IMO a separate
> interface would be better. Any opinions?
I agree that a separate interface would be better, one that guarantees to
handle exceptions on the m68k and other archs with separate address spaces too.
I use that facility quite regularly in architecture specific code, sorry
for letting it slip into portable code.
I guess set_fs(KERNEL_DS); __*_user() will not catch exceptions on m68k
currently, right?
-Andi
next prev parent reply other threads:[~2002-03-12 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-12 11:58 __get_user usage in mm/slab.c Roman Zippel
2002-03-12 12:43 ` David S. Miller
2002-03-12 13:18 ` vinolin
2002-03-12 15:23 ` Andi Kleen [this message]
2002-03-12 15:25 ` David S. Miller
2002-03-12 16:32 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020312162316.A3505@averell \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.