Re: oops at boot with 2.5.7 and i810 (reiserFS related?)

[Oleg Drokin <green@namesys.com>]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

Hello!

On Thu, Mar 21, 2002 at 06:41:49PM +0100, Luigi Genoni wrote:

> It seems that a lot of users had oops mounting reiserFS with 2.5.6, but
> then a patch fixed that. Now I think this patch is in 2.5.7, (it should),
> but there are other changes i think to reiserFS code. So i have other
> oopses.

reiserfs in 2.5.6-pre3 to 2.5.7 have a bug that prevent it from mounting
usual filesystems (filesystems with relocated journals still works,
but I doubt much people use that).
 
> I think this could be a proof of a reiserFS bug.

Sure.

> If people at namesys need it (maybe they already know this, and have a
> patch to try), tomorrow i will post the oop mounting
> reiserFS.

No need for that. See attached patch that I am posting in response to
any such report (so just looking in archives first might help you faster).

Bye,
    Oleg

[-- Attachment #2: 00-jdev_bd_merging_fix.diff --]
[-- Type: text/plain, Size: 881 bytes --]

--- linux-2.5.6/fs/reiserfs/journal.c.orig	Tue Mar 12 15:25:27 2002
+++ linux-2.5.6/fs/reiserfs/journal.c	Tue Mar 12 15:26:47 2002
@@ -1958,8 +1958,7 @@
       		SB_ONDISK_JOURNAL_DEVICE( super ) ?
 		to_kdev_t(SB_ONDISK_JOURNAL_DEVICE( super )) : super -> s_dev;	
 	/* there is no "jdev" option and journal is on separate device */
-	if( ( !jdev_name || !jdev_name[ 0 ] ) && 
-	    SB_ONDISK_JOURNAL_DEVICE( super ) ) {
+	if( ( !jdev_name || !jdev_name[ 0 ] ) ) {
 		journal -> j_dev_bd = bdget( kdev_t_to_nr( jdev ) );
 		if( journal -> j_dev_bd )
 			result = blkdev_get( journal -> j_dev_bd, 
@@ -1974,9 +1973,6 @@
 		return result;
 	}
 
-	/* no "jdev" option and journal is on the host device */
-	if( !jdev_name || !jdev_name[ 0 ] )
-		return 0;
 	journal -> j_dev_file = filp_open( jdev_name, 0, 0 );
 	if( !IS_ERR( journal -> j_dev_file ) ) {
 		struct inode *jdev_inode;