From: Russell King <rmk@arm.linux.org.uk>
To: Eyal Lebedinsky <eyal@eyal.emu.id.au>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.4.19-pre5: bad config
Date: Sat, 30 Mar 2002 09:06:02 +0000 [thread overview]
Message-ID: <20020330090602.B23576@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.21.0203291842530.6417-100000@freak.distro.conectiva> <3CA502A0.54547786@eyal.emu.id.au>
On Sat, Mar 30, 2002 at 11:11:12AM +1100, Eyal Lebedinsky wrote:
> In drivers/mtd/maps/Config.in CONFIG_ARM is used in the condition, so
> maybe a better patch will be to do the same here? I leave this to the
> experts.
I have a patch for this.
> -dep_tristate ' SA1100 support' CONFIG_PCMCIA_SA1100 $CONFIG_ARCH_SA1100 $CONFIG_PCMCIA
> +if [ "$CONFIG_ARCH_SA1100" = "y" ]; then
> + dep_tristate ' SA1100 support' CONFIG_PCMCIA_SA1100 $CONFIG_PCMCIA
> +fi
It's basically to wrap it in an CONFIG_ARM and leave the SA1100 dependency.
Why? There are other ARM PCMCIA drivers, and rather have a mass of if
statements, I'd rather see dep_*
I'll dig out the patch later today.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-03-30 9:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-29 21:47 Linux 2.4.19-pre5 Marcelo Tosatti
2002-03-30 0:11 ` Linux 2.4.19-pre5: bad config Eyal Lebedinsky
2002-03-30 9:06 ` Russell King [this message]
2002-03-30 10:19 ` Russell King
2002-03-30 17:46 ` Alan Cox
2002-03-30 19:13 ` Russell King
2002-03-30 0:23 ` Linux 2.4.19-pre5: neofb.c compile failure Eyal Lebedinsky
2002-03-30 20:40 ` Linux 2.4.19-pre5 Michal Jaegermann
2002-03-30 23:34 ` Keith Owens
2002-03-31 1:41 ` Michal Jaegermann
2002-03-31 0:39 ` Linux 2.4.19-pre5: hotplug config Eyal Lebedinsky
2002-03-31 14:02 ` Alan Cox
2002-03-31 17:53 ` Greg KH
2002-04-01 0:11 ` Alan Cox
2002-04-04 19:50 ` Linux 2.4.19-pre5 Adrian Bunk
2002-04-04 21:41 ` Marcelo Tosatti
2002-04-09 2:42 ` Reworked CONFIG_IDE_TASKFILE_IO help text Thomas Zimmerman
2002-04-09 6:01 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020330090602.B23576@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=eyal@eyal.emu.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.