From: raoul@shuttle.de (Raoul Borenius)
To: Ralf Baechle <ralf@oss.sgi.com>
Cc: linux-mips@oss.sgi.com, devfs@oss.sgi.com
Subject: Re: broken devfs-support in SGI Zilog8530 serial driver
Date: Sun, 31 Mar 2002 17:00:23 +0200 [thread overview]
Message-ID: <20020331150023.GA30224@bunny.shuttle.de> (raw)
In-Reply-To: <20020330132856.GA24305@bunny.shuttle.de>
Hi Ralf,
On Sat, Mar 30, 2002 at 02:28:56PM +0100, raoul wrote:
> Especially because you only need the small change pointed out by
> Russell Coker:
>
> --- sgiserial.c.orig Sat Mar 30 10:51:03 2002
> +++ sgiserial.c Sat Mar 30 10:54:28 2002
> @@ -1875,7 +1875,11 @@
>
> memset(&serial_driver, 0, sizeof(struct tty_driver));
> serial_driver.magic = TTY_DRIVER_MAGIC;
> +#ifdef CONFIG_DEVFS_FS
> + serial_driver.name = "tts/%d";
> +#else
> serial_driver.name = "ttyS";
> +#endif
> serial_driver.major = TTY_MAJOR;
> serial_driver.minor_start = 64;
> serial_driver.num = NUM_CHANNELS;
Thanks for including the changes fr the ttyS's. But it seems you forgot the
callout-devices:
> @@ -1911,7 +1915,11 @@
> * major number and the subtype code.
> */
> callout_driver = serial_driver;
> +#ifdef CONFIG_DEVFS_FS
> + callout_driver.name = "cua/%d";
> +#else
> callout_driver.name = "cua";
> +#endif
> callout_driver.major = TTYAUX_MAJOR;
> callout_driver.subtype = SERIAL_TYPE_CALLOUT;
>
Could you commit that too?
Thanx
Raoul
next prev parent reply other threads:[~2002-03-31 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-29 10:32 broken devfs-support in SGI Zilog8530 serial driver Raoul Borenius
2002-03-29 11:01 ` Borsenkow Andrej
2002-03-29 13:26 ` Raoul Borenius
2002-03-29 13:38 ` Russell Coker
2002-03-29 13:38 ` Russell Coker
2002-03-30 7:35 ` Ralf Baechle
2002-03-30 13:28 ` Raoul Borenius
2002-03-30 20:18 ` Ralf Baechle
2002-03-31 15:00 ` Raoul Borenius [this message]
2002-03-31 22:15 ` Ralf Baechle
2002-04-01 19:29 ` Florian Lohoff
2002-04-01 22:16 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020331150023.GA30224@bunny.shuttle.de \
--to=raoul@shuttle.de \
--cc=devfs@oss.sgi.com \
--cc=linux-mips@oss.sgi.com \
--cc=ralf@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.