All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: roger blofeld <blofeldus@yahoo.com>
Cc: <linuxppc-dev@lists.linuxppc.org>
Subject: Re: Patch: Fix SMP hang on modem close
Date: Sat, 6 Apr 2002 12:24:10 +0200	[thread overview]
Message-ID: <20020406102410.14763@smtp.wanadoo.fr> (raw)
In-Reply-To: <20020405202021.61407.qmail@web11105.mail.yahoo.com>


>
>Ben,
> This patch removes two dangling LOCK() statements for
>core99/pangea. The core99 one hung my dual g4.
>-roger

Good catch ! That would indeed have cause SMP lockups
when using the modem.

Thanks,
Ben.

>--- linux/arch/ppc/kernel/pmac_feature.c.orig   Tue
>Apr  2 08:17:31 2002
>+++ linux/arch/ppc/kernel/pmac_feature.c        Fri
>Apr  5 14:02:13 2002
>@@ -788,7 +788,7 @@
>                UNLOCK(flags); mdelay(250);
>LOCK(flags);
>                MACIO_OUT8(KL_GPIO_MODEM_RESET, gpio |
>KEYLARGO_GPIO_OUTOUT_DATA);
>                (void)MACIO_IN8(KL_GPIO_MODEM_RESET);
>-               UNLOCK(flags); mdelay(250);
>LOCK(flags);
>+               UNLOCK(flags); mdelay(250);
>        }
>        return 0;
> }
>@@ -1445,7 +1445,7 @@
>                UNLOCK(flags); mdelay(250);
>LOCK(flags);
>                MACIO_OUT8(KL_GPIO_MODEM_RESET, gpio |
>KEYLARGO_GPIO_OUTOUT_DATA);
>                (void)MACIO_IN8(KL_GPIO_MODEM_RESET);
>-               UNLOCK(flags); mdelay(250);
>LOCK(flags);
>+               UNLOCK(flags); mdelay(250);
>        }
>        return 0;
> }
>
>
>


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2002-04-06 10:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-05 20:20 Patch: Fix SMP hang on modem close roger blofeld
2002-04-06 10:24 ` Benjamin Herrenschmidt [this message]
2002-06-06 19:25   ` Sungem bug or something else? roger blofeld
2002-06-06 19:30     ` Tom Rini
2002-06-06 19:45     ` Benjamin Herrenschmidt
2002-06-06 20:35       ` roger blofeld
2002-06-06 20:41       ` Kevin B. Hendricks
2002-06-06 20:25         ` benh
2002-06-06 21:02         ` roger blofeld
2002-06-07  0:51       ` roger blofeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020406102410.14763@smtp.wanadoo.fr \
    --to=benh@kernel.crashing.org \
    --cc=blofeldus@yahoo.com \
    --cc=linuxppc-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.