All of lore.kernel.org
 help / color / mirror / Atom feed
From: Morten Helgesen <admin@nextframe.net>
To: Francois Romieu <romieu@cogenit.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.5.8-pre3 - drivers/net/wan/farsync.c
Date: Fri, 12 Apr 2002 13:57:22 +0200	[thread overview]
Message-ID: <20020412135722.H6609@sexything> (raw)
In-Reply-To: <20020412133438.A5627@fafner.intra.cogenit.fr>

Hey, Francois! 

I`ve been working with Kevin Curtis <kevin.curtis@farsite.co.uk> (the current maintainer of farsync.c) the last couple
of days, and we`ve performed a bit of spring cleaning, including pci_enable_device() fixes and this fix for
dev->rmem_end/start. Kevin also said he has been working on performance issues, so the next release of this driver should be
really fancy :) 

Right, Kevin ? :)

== Morten

On Fri, Apr 12, 2002 at 01:34:38PM +0200, Francois Romieu wrote:
> Greetings,
> 
> Problem:
> compilation fails due to removal of rmem_{start/end} in struct net_device.
> 
> Fix:
> Simple removal. I haven't found any other use of these fields in the driver.
> 
> --- linux-2.5.8-pre3.orig/drivers/net/wan/farsync.c	Thu Apr 11 23:51:52 2002
> +++ linux-2.5.8-pre3/drivers/net/wan/farsync.c	Thu Apr 11 23:55:24 2002
> @@ -1469,10 +1469,6 @@ fst_init_card ( struct fst_card_info *ca
>                                   + BUF_OFFSET ( txBuffer[i][0][0]);
>                  dev->mem_end     = card->phys_mem
>                                   + BUF_OFFSET ( txBuffer[i][NUM_TX_BUFFER][0]);
> -                dev->rmem_start  = card->phys_mem
> -                                 + BUF_OFFSET ( rxBuffer[i][0][0]);
> -                dev->rmem_end    = card->phys_mem
> -                                 + BUF_OFFSET ( rxBuffer[i][NUM_RX_BUFFER][0]);
>                  dev->base_addr   = card->pci_conf;
>                  dev->irq         = card->irq;
>  
> -- 
> Ueimor
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 

"Livet er ikke for nybegynnere" - sitat fra en klok person.

mvh
Morten Helgesen 
UNIX System Administrator & C Developer 
Nextframe AS
admin@nextframe.net / 93445641
http://www.nextframe.net

  reply	other threads:[~2002-04-12 11:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-12 11:34 [patch] 2.5.8-pre3 - drivers/net/wan/farsync.c Francois Romieu
2002-04-12 11:57 ` Morten Helgesen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-04-12 13:30 Kevin Curtis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020412135722.H6609@sexything \
    --to=admin@nextframe.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romieu@cogenit.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.