Re: [PATCH] IDE TCQ #4

[Jens Axboe <axboe@suse.de>]

On Thu, Apr 18 2002, Martin Dalecki wrote:
> Jens Axboe wrote:
> >On Thu, Apr 18 2002, Martin Dalecki wrote:
> >
> >>Jens Axboe wrote:
> >>
> >>>On Thu, Apr 18 2002, Martin Dalecki wrote:
> >>>
> >>>
> >>>>BTW>  Jens: Do you have any idea what the "sector chaing" in ide-cd is
> >>>>good for?! I would love to just get rid of it alltogether!
> >>>
> >>>
> >>>Sector chaining? Are you talking about the cdrom_read_intr() comments?
> >>
> >>Sorry I did mean sector caching.
> >
> >
> >That's for padding/caching sub-frame sized reads.
> 
> I tought the BIO layer did this alredy... Well it's a pain

Nope, it does not.

> in the a** to deal with it. IDE-FLOPPY is passing packet commands

It sure is... sr doesn't do it and lots of others don't as well, so I
suppose we could rip it out. We already require reblocking with loop in
those cases anyway.

> through the request buffer but IDE-CD is passing them through
> request special field... argh!

So kill ->special usage in ide-cd and use ->buffer?

-- 
Jens Axboe