Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[A Guy Called Tyketto <tyketto@wizard.com>]

        IMHO, this isn't good. I just gave this a run with 2.5.15, and 
opl3_oss.c wasn't even touched during compile (either into the kernel or as a 
module); it's completely passed over. more than likely when inserted with 
modprobe, OSS emulation would fail from functions not being there. I haven't 
tried that yet, but this would be my guess..

                                                        BL.
On Thu, May 09, 2002 at 02:21:32PM +0200, Zwane Mwaikambo wrote:
> Not so sure wether the ifeq change is what you want though...
> 
> --- linux-2.5/sound/drivers/opl3/Makefile.orig	Thu May  9 12:38:42 2002
> +++ linux-2.5/sound/drivers/opl3/Makefile	Thu May  9 12:39:20 2002
> @@ -9,7 +9,7 @@
>  
>  snd-opl3-lib-objs := opl3_lib.o opl3_synth.o
>  snd-opl3-synth-objs := opl3_seq.o opl3_midi.o opl3_drums.o
> -ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
> +ifeq ($(subst m,y,$(CONFIG_SND_OSSEMUL)),y)
>  snd-opl3-synth-objs += opl3_oss.o
>  endif
>  
> --- linux-2.5/include/sound/opl3.h.orig	Thu May  9 12:34:10 2002
> +++ linux-2.5/include/sound/opl3.h	Thu May  9 12:34:18 2002
> @@ -287,8 +287,10 @@
>  	snd_seq_device_t *seq_dev;	/* sequencer device */
>  	snd_midi_channel_set_t * chset;
>  
> +#ifdef CONFIG_SND_OSSEMUL
>  	snd_seq_device_t *oss_seq_dev;	/* OSS sequencer device, WIP */
>  	snd_midi_channel_set_t * oss_chset;
> +#endif
>   
>  	snd_seq_kinstr_ops_t fm_ops;
>  	snd_seq_kinstr_list_t *ilist;
> 
> -- 
> http://function.linuxpower.ca
> 		
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Brad Littlejohn                         | Email:        tyketto@wizard.com
Unix Systems Administrator,             |           tyketto@ozemail.com.au
Web + NewsMaster, BOFH.. Smeghead! :)   |   http://www.wizard.com/~tyketto
  PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569  F620 C819 199A E319 F0BF