From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Stephen C. Tweedie" <sct@redhat.com>
Subject: Re: [Ext2-devel] Re: ext3 -> crash -> fsck -> readlink -> oops
Date: Fri, 17 May 2002 10:40:34 +0100
Sender: linux-fsdevel-owner@vger.kernel.org
Message-ID: <20020517104034.B2693@redhat.com>
References: <ac1k4v$ce0$1@cesium.transmeta.com> <3CE46CF0.E0C9BCC5@zip.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "H. Peter Anvin" <hpa@zytor.com>, linux-fsdevel@vger.kernel.org,
	ext2-devel@lists.sourceforge.net
Return-path: <linux-fsdevel-owner@vger.kernel.org>
To: Andrew Morton <akpm@zip.com.au>
Content-Disposition: inline
In-Reply-To: <3CE46CF0.E0C9BCC5@zip.com.au>; from akpm@zip.com.au on Thu, May 16, 2002 at 07:37:36PM -0700
List-Id: linux-fsdevel.vger.kernel.org

Hi,

On Thu, May 16, 2002 at 07:37:36PM -0700, Andrew Morton wrote:

> -	len = strlen(link);
> +	len = strnlen(link, PAGE_CACHE_SIZE);
>  	if (len > (unsigned) buflen)
>  		len = buflen;

Well, if we're going to be testing against buflen anyway, then

--- fs/namei.c.~1~	Thu May  9 17:13:32 2002
+++ fs/namei.c	Fri May 17 10:37:58 2002
@@ -1947,9 +1947,7 @@
 	if (IS_ERR(link))
 		goto out;
 
-	len = strlen(link);
-	if (len > (unsigned) buflen)
-		len = buflen;
+	len = strnlen(link, buflen);
 	if (copy_to_user(buffer, link, len))
 		len = -EFAULT;
 out:

is cleaner.

--Stephen