From: David Gibson <david@gibson.dropbear.id.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: [TRIVIAL PATCH] Fix order of #includes in init/version.c
Date: Tue, 21 May 2002 12:19:52 +1000 [thread overview]
Message-ID: <20020521021952.GD4745@zax> (raw)
Linus, please apply. compile.h must be #included before uts.h, or
uts.h will define UTS_MACHINE (incorrectly) which is then redefined in
compile.h.
diff -urN /home/dgibson/kernel/linuxppc-2.5/init/version.c linux-bluefish/init/version.c
--- /home/dgibson/kernel/linuxppc-2.5/init/version.c Tue Feb 5 18:55:11 2002
+++ linux-bluefish/init/version.c Tue May 21 12:06:11 2002
@@ -6,10 +6,10 @@
* May be freely distributed as part of Linux.
*/
+#include <linux/compile.h>
#include <linux/uts.h>
#include <linux/utsname.h>
#include <linux/version.h>
-#include <linux/compile.h>
#define version(a) Version_ ## a
#define version_string(a) version(a)
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong. -- H.L. Mencken
http://www.ozlabs.org/people/dgibson
reply other threads:[~2002-05-21 2:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020521021952.GD4745@zax \
--to=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.