From: David Gibson <david@gibson.dropbear.id.au>
To: Armin Kuster <akuster@mvista.com>
Cc: Dan Malek <dan@embeddededge.com>,
Tom Rini <trini@kernel.crashing.org>,
linuxppc-embedded@lists.linuxppc.org,
Paul Mackerras <paulus@samba.org>
Subject: Re: Another OCP enet patch
Date: Thu, 30 May 2002 13:10:50 +1000 [thread overview]
Message-ID: <20020530031050.GK16537@zax> (raw)
In-Reply-To: <3CF4FB77.3010203@mvista.com>
On Wed, May 29, 2002 at 09:01:59AM -0700, Armin Kuster wrote:
>
> Dan Malek wrote:
>
> >We can't change the PCI names, so I just suggested we change the names to
> >consistent_sync(), define those in io.h (so non-PCI systems don't have to
> >include pci header files just to get a flag name), and put a big comment
> >around the flag definitions that they have to match the PCI_ names.
>
> Why not put the flag definition in a /linux/dma.h and include that in
> /linux/pci.h. Have the pci flags be defined as the ones in dma.h. That
> way it's obvious where the orginal defines are and easier to
> maintain. :)
That's what I'd like to do, but it means changes to generic code, so
Linus needs to be convinced.
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong. -- H.L. Mencken
http://www.ozlabs.org/people/dgibson
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-05-30 3:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-27 4:03 Another OCP enet patch David Gibson
2002-05-27 6:14 ` Armin Kuster
2002-05-27 16:23 ` Tom Rini
2002-05-28 0:57 ` David Gibson
2002-05-28 1:25 ` Tom Rini
2002-05-28 6:36 ` David Gibson
2002-05-28 15:08 ` Tom Rini
2002-05-28 7:02 ` Armin
2002-05-28 6:50 ` David Gibson
2002-05-28 10:51 ` Dan Malek
2002-05-29 3:48 ` David Gibson
2002-05-29 14:51 ` Dan Malek
2002-05-28 10:39 ` Dan Malek
2002-05-29 4:16 ` David Gibson
2002-05-29 15:02 ` Dan Malek
2002-05-29 16:01 ` Armin Kuster
2002-05-30 3:10 ` David Gibson [this message]
2002-05-30 3:09 ` David Gibson
2002-05-30 4:16 ` Dan Malek
2002-05-30 4:30 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020530031050.GK16537@zax \
--to=david@gibson.dropbear.id.au \
--cc=akuster@mvista.com \
--cc=dan@embeddededge.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=paulus@samba.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.