From: Rasmus Andersen <rasmus@jaquet.dk>
To: "Anthony J. Breeds-Taurima" <tony@cantech.net.au>
Cc: lkml <linux-kernel@vger.kernel.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Rogier Wolff <R.E.Wolff@BitWizard.nl>
Subject: Re: [PATCH] 2.4.19-pre10 s/Efoo/-Efoo/ drivers/char/rio/*.c
Date: Tue, 4 Jun 2002 11:00:32 +0200 [thread overview]
Message-ID: <20020604110032.A28843@jaquet.dk> (raw)
In-Reply-To: <Pine.LNX.4.44.0206041643070.32156-100000@thor.cantech.net.au>
On Tue, Jun 04, 2002 at 04:48:58PM +0800, Anthony J. Breeds-Taurima wrote:
> Hello All,
> This is another cleanup patch changing positive return values into
> negative's.
>
>
> Yours Tony
>
> Jan 22-26 2003 Linux.Conf.AU http://conf.linux.org.au/
> The Australian Linux Technical Conference!
>
> --------------------------------------------------------------------------------
> diff -X dontdiff -urN linux-2.4.19-pre10.clean/drivers/char/rio/rio_linux.c linux-2.4.19-pre10/drivers/char/rio/rio_linux.c
> --- linux-2.4.19-pre10.clean/drivers/char/rio/rio_linux.c Tue Apr 30 13:22:07 2002
> +++ linux-2.4.19-pre10/drivers/char/rio/rio_linux.c Tue Jun 4 16:27:36 2002
> @@ -702,7 +702,7 @@
> func_enter();
>
> /* The "dev" argument isn't used. */
> - rc = -riocontrol (p, 0, cmd, (void *)arg, suser ());
> + rc = riocontrol (p, 0, cmd, (void *)arg, suser ());
I'm sorry but since this code indeed changes the positive return
codes into negatives, what is the purpose of your patch? Have you
talked to the maintainer (R.E.Wolff)?
Rasmus
next prev parent reply other threads:[~2002-06-04 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-04 8:48 [PATCH] 2.4.19-pre10 s/Efoo/-Efoo/ drivers/char/rio/*.c Anthony J. Breeds-Taurima
2002-06-04 9:00 ` Rasmus Andersen [this message]
2002-06-04 10:32 ` Anthony J. Breeds-Taurima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020604110032.A28843@jaquet.dk \
--to=rasmus@jaquet.dk \
--cc=R.E.Wolff@BitWizard.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=tony@cantech.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.