All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexey.vyskubov@nokia.com (Alexey Vyskubov)
To: linux-kernel@vger.kernel.org
Cc: torvalds@transmeta.com
Subject: Bug in asm-i386/rwlock.h
Date: Tue, 4 Jun 2002 17:08:55 +0300	[thread overview]
Message-ID: <20020604140855.GA6967@terrapin> (raw)

Hello.

We suppose that include/asm-i386/rwlock.h contains a bug.

Under some circumstances (compiling some external modules + no
optimization + SMP) it's possible to get the following error:

/tmp/ccw7qDe1.s: Assembler messages:
/tmp/ccw7qDe1.s:6815: Error: bad expression
/tmp/ccw7qDe1.s:6815: Error: missing ')'
/tmp/ccw7qDe1.s:6815: Error: missing ')'
/tmp/ccw7qDe1.s:6815: Error: junk `ebx))' after expression

We believe that it's a typo in include/asm-i386/rwlock.h

--- include/asm-i386/rwlock.h.orig      Tue Jun  4 16:32:38 2002
+++ include/asm-i386/rwlock.h   Tue Jun  4 16:33:02 2002
@@ -61,7 +61,7 @@
                     ::"a" (rw) : "memory")
 
 #define __build_write_lock_const(rw, helper) \
-       asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",(%0)\n\t" \
+       asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",%0\n\t" \
                     "jnz 2f\n" \
                     "1:\n" \
                     ".section .text.lock,\"ax\"\n" \

-- 
Alexey Vyskubov
Dmitry Kasatkin
Nokia Research Center / Helsinki

                 reply	other threads:[~2002-06-04 14:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020604140855.GA6967@terrapin \
    --to=alexey.vyskubov@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.