From: Russell King <rmk@arm.linux.org.uk>
To: Lightweight patch manager <patch@luckynet.dynu.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH][2.5] Double quote patches part one: drivers 1/2
Date: Tue, 11 Jun 2002 08:47:58 +0100 [thread overview]
Message-ID: <20020611084758.B1346@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0206102101520.20111-100000@hawkeye.luckynet.adm>
On Mon, Jun 10, 2002 at 09:07:17PM -0600, Lightweight patch manager wrote:
> I spent my whole night correcting the double quotes. Someone pointed out
> yesterday that they had to be corrected. I did a checker script and am now
> running over the kernel.
>
> This patch fixes broken double quotes in printk's and asm's.
Not "broken" as such. Just "new gcc warns".
> + " subs %3, %3, #2 \n"
> + " bmi 2f \n"
> + "1: \n"
Yuck. Yuck yuck yuck yuck yuck.
1. Spaces -> source bloat.
2. No tab at the start of the file -> yuck when reading the ASM.
My preferred way of fixing these in ARM stuff is to add <tab><tab><tab>\n\
to each line (with the appropriate number of tabs. See
arch/arm/kernel/semaphore.c for an example.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-06-11 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-11 3:07 [PATCH][2.5] Double quote patches part one: drivers 1/2 Lightweight patch manager
2002-06-11 7:47 ` Russell King [this message]
2002-06-11 10:24 ` Thunder from the hill
2002-06-11 10:43 ` Russell King
2002-06-11 15:16 ` David Woodhouse
2002-06-11 16:54 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020611084758.B1346@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=patch@luckynet.dynu.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.