From: kuebelr@email.uc.edu
To: trivial@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] [TRIVIAL] tdfxfb - compiler warning
Date: Wed, 12 Jun 2002 23:46:00 -0400 [thread overview]
Message-ID: <20020613034600.GA3927@cartman> (raw)
When tdfxfb is compiled into the kernel proper, tdfxfb_remove is not
needed. Don't compile it if we don't need it. There is one other
reference to tdfxfb_remove in tdfxfb.c but, __devexit_p() takes care of
it.
Patch is against 2.4.19-pre10.
Rob.
diff -aur linux-clean/drivers/video/tdfxfb.c linux-dirty/drivers/video/tdfxfb.c
--- linux-clean/drivers/video/tdfxfb.c Mon Feb 25 14:38:07 2002
+++ linux-dirty/drivers/video/tdfxfb.c Sat Jun 8 12:32:23 2002
@@ -464,7 +464,9 @@
* PCI driver prototypes
*/
static int tdfxfb_probe(struct pci_dev *pdev, const struct pci_device_id *id);
+#ifdef MODULE
static void tdfxfb_remove(struct pci_dev *pdev);
+#endif
static int currcon = 0;
@@ -2037,6 +2039,7 @@
return 0;
}
+#ifdef MODULE
/**
* tdfxfb_remove - Device removal
*
@@ -2061,6 +2064,7 @@
iounmap(fb_info.regbase_virt);
iounmap(fb_info.bufbase_virt);
}
+#endif
int __init tdfxfb_init(void)
{
next reply other threads:[~2002-06-13 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-13 3:46 kuebelr [this message]
2002-06-13 5:19 ` [PATCH] [TRIVIAL] tdfxfb - compiler warning Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020613034600.GA3927@cartman \
--to=kuebelr@email.uc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.