All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhishek Nayani <abhi@kernelnewbies.org>
To: linux-kernel@vger.kernel.org
Subject: Doubt (bug?) in dup_mmap()
Date: Fri, 14 Jun 2002 23:13:53 +0530	[thread overview]
Message-ID: <20020614174353.GA3792@SandStorm.net> (raw)

Hi all,

	In the function dup_mmap() in kernel/fork.c, 

	file = tmp->vm_file;
	if (file) {
		struct inode *inode = file->f_dentry->d_inode;
		get_file(file);
		if(tmp->vm_flags & VM_DENYWRITE)
			atomic_dec(&inode->i_writecount);

	After this piece of code, shouldn't there be :
	
		else
			atomic_inc(&inode->i_writecount);

	as this is a read-write mapping ?
	
				
					Bye,
						Abhi.
	
Linux Kernel Documentation Project
http://freesoftware.fsf.org/lkdp

	
--------------------------------------------------------------------------------
Those who cannot remember the past are condemned to repeat it - George Santayana
--------------------------------------------------------------------------------
                          Home Page: http://www.abhi.tk
-----BEGIN GEEK CODE BLOCK------------------------------------------------------
GCS d+ s:- a-- C+++ UL P+ L+++ E- W++ N+ o K- w--- O-- M- V- PS PE Y PGP 
t+ 5 X+ R- tv+ b+++ DI+ D G e++ h! !r y- 
------END GEEK CODE BLOCK-------------------------------------------------------


                 reply	other threads:[~2002-06-16 18:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020614174353.GA3792@SandStorm.net \
    --to=abhi@kernelnewbies.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.