From: Dave Jones <davej@suse.de>
To: Bob Miller <rem@osdl.org>
Cc: Benjamin LaHaise <bcrl@redhat.com>,
Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] v2.5.22 - add wait queue function callback support
Date: Mon, 17 Jun 2002 23:08:32 +0200 [thread overview]
Message-ID: <20020617230831.J758@suse.de> (raw)
In-Reply-To: <20020617135744.A24347@doc.pdx.osdl.net>; from rem@osdl.org on Mon, Jun 17, 2002 at 01:57:44PM -0700
On Mon, Jun 17, 2002 at 01:57:44PM -0700, Bob Miller wrote:
> > I thought we killed off wq_write_lock_irqsave 1-2 kernels ago ?
> It depends on what you mean by killed off. I submitted a patch to Linus back
> at 2.5.3 to clean up the way the completion code called the wait queue
> interface. This interface got added then. You picked up those changes at
> that time (and still have them in your kernel tree) but the changes have
> never made it into Linus' tree.
>
> So, Linus has never had the code to 'kill' and you've never dropped it
> after picking it up.
Your patch was to use wq_write_lock and friends in sched.c iirc.
That change is now removed from my tree (though I've not put up a
version containing that change yet).
Since 2.5.20 or so, the wq_write_lock functions are dead as in gone.
Not around, Extinct. They are ex-functions.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-06-17 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-17 20:14 [patch] v2.5.22 - add wait queue function callback support Benjamin LaHaise
2002-06-17 20:28 ` Dave Jones
2002-06-17 20:53 ` Benjamin LaHaise
2002-06-17 21:02 ` Linus Torvalds
2002-06-17 22:09 ` Benjamin LaHaise
2002-06-17 22:20 ` Linus Torvalds
2002-06-17 20:57 ` Bob Miller
2002-06-17 21:08 ` Dave Jones [this message]
2002-06-17 21:23 ` Bob Miller
2002-06-17 21:12 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020617230831.J758@suse.de \
--to=davej@suse.de \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rem@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.