All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@clusterfs.com>
To: Ian Prowell <ip_lvm@prowell.org>
Cc: linux-lvm@sistina.com
Subject: Re: [linux-lvm] ext2online and 2.4.18
Date: Wed Jun 19 16:49:02 2002	[thread overview]
Message-ID: <20020619214731.GB22427@clusterfs.com> (raw)
In-Reply-To: <1024521044.1861.6.camel@hiro.prowell.org.bogus>

On Jun 19, 2002  14:10 -0700, Ian Prowell wrote:
> Andreas,
> Thanks for the prompt reply.  To be more specific I am using RedHat's
> 2.4.18-4 kernel.  When I apply the patch I get the following output.
> 
> [root@metaverse src]# cat /root/online-ext2-2.4.17.diff | patch -p0
> patching file linux/fs/ext2/super.c
> Hunk #9 succeeded at 730 (offset -1 lines).
> Hunk #10 FAILED at 883.
> Hunk #11 succeeded at 893 (offset 1 line).
> Hunk #12 succeeded at 917 (offset -1 lines).
> Hunk #13 succeeded at 979 (offset 1 line).
> Hunk #14 succeeded at 987 (offset -1 lines).
> Hunk #15 succeeded at 1024 (offset 1 line).
> 1 out of 15 hunks FAILED -- saving rejects to file
> linux/fs/ext2/super.c.rej
> 
> It looks like most of the patch is working, but I am not a kernel
> developer and really have no idea what failed on hunk 10.  If it would
> be useful I can send the rejects file.

It won't really be useful for you to send the failed hunk, because I
have no idea why it is failing.  I would suggest firing up a text editor
with fs/ext2/super.c and fs/ext2/super.c.rej and just manually cut-paste
the failed parts in.

Unified diffs are rather simple to understand.

Lines like "@@ -123,6 +234,8 @@" are telling you that the original file
had this hunk at line 123 and the modified file had the replacement
hunk at line 234.

Lines like "-                blah" are removing that line from the
original file and replacing it with "+           blarg" in the new file.

Hopefully hunk #10 isn't too large...  Sadly, the larger the hunk, the
more likely it is to not apply cleanly...

Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/

  reply	other threads:[~2002-06-19 16:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-19 13:56 [linux-lvm] ext2online and 2.4.18 Ian Prowell
2002-06-19 14:12 ` Andres Salomon
2002-06-19 14:57 ` Andreas Dilger
2002-06-19 16:11   ` Ian Prowell
2002-06-19 16:49     ` Andreas Dilger [this message]
2002-06-19 17:27       ` Ian Prowell
2002-06-20  6:28         ` sander
2002-06-20 11:36           ` Andreas Dilger
2002-06-21 16:49             ` Re[2]: " Sander
2002-06-21 16:59               ` Jan-Benedict Glaw
2002-06-22  4:32                 ` Re[2]: " Sander
2002-06-22  3:13               ` Andreas Dilger
2002-06-22 12:11                 ` Re[2]: " sander
  -- strict thread matches above, loose matches on Subject: below --
2002-06-21 17:06 Sander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020619214731.GB22427@clusterfs.com \
    --to=adilger@clusterfs.com \
    --cc=ip_lvm@prowell.org \
    --cc=linux-lvm@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.