Re: 2.5.23+ bootflag.c triggers __iounmap: bad address

[Andi Kleen <ak@suse.de>]

On Fri, Jun 21, 2002 at 01:56:55PM +0200, Mikael Pettersson wrote:
> When booting 2.5.23/.24, my test boxes generate the following:
> 
> (an ASUS P4T-E which has SBF)
> __iounmap: bad address d0802100
> SBF: Simple Boot Flag extension found and enabled.
> __iounmap: bad address d0805040
> __iounmap: bad address d0808080
> SBF: Setting boot flags 0x1
> 
> (an old Intel AL440LX which doesn't have SBF)
> __iounmap: bad address c4800009
> __iounmap: bad address c4804b8c
> __iounmap: bad address c4802009
> 
> These warnings/errors are new since 2.5.23, which makes me
> suspect something's wrong in the 2.5.23 iounmap changes.

Does this patch fix it?


-Andi



--- linux-2.5.23-work/arch/i386/mm/ioremap.c.~2~	Tue Jun 18 02:13:09 2002
+++ linux-2.5.23-work/arch/i386/mm/ioremap.c	Fri Jun 21 14:42:23 2002
@@ -213,9 +213,9 @@
 void iounmap(void *addr)
 { 
 	struct vm_struct *p;
-	if (addr < high_memory) 
+	if (addr <= high_memory) 
 		return; 
-	p = remove_kernel_area(addr); 
+	p = remove_kernel_area(PAGE_MASK & (unsigned long) addr); 
 	if (!p) { 
 		printk("__iounmap: bad address %p\n", addr);
 		return;