From: Ralf Baechle <ralf@oss.sgi.com>
To: Carsten Langgaard <carstenl@mips.com>
Cc: linux-mips@oss.sgi.com
Subject: Re: sys_syscall patch.
Date: Mon, 24 Jun 2002 11:54:52 +0200 [thread overview]
Message-ID: <20020624115452.A25138@dea.linux-mips.net> (raw)
In-Reply-To: <3D16E14C.5C8D2FAD@mips.com>; from carstenl@mips.com on Mon, Jun 24, 2002 at 11:07:24AM +0200
On Mon, Jun 24, 2002 at 11:07:24AM +0200, Carsten Langgaard wrote:
> The 'sys_syscall' syscall isn't properly implemented in the 64-bit
> kernel (for o32 as well as n64).
> Below is a patch, it seems to work for in the o32 case, but I haven't
> tested the n64 version (obviously).
> +/*
> + * Do the indirect syscall syscall.
> + * Don't care about kernel locking; the actual syscall will do it.
> + *
> + * XXX This is broken.
> + */
As the comment says - it's broken. This implementation just like it's
32-bit predecessor don't handle the error return value correctly. Worse,
there's unprotected accesses to userspace which allow any user crashing
the system ...
Ralf
next prev parent reply other threads:[~2002-06-24 9:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-24 9:07 sys_syscall patch Carsten Langgaard
2002-06-24 9:54 ` Ralf Baechle [this message]
2002-06-24 10:06 ` Carsten Langgaard
2002-06-24 10:24 ` Ralf Baechle
2002-06-24 10:46 ` Carsten Langgaard
2002-06-24 11:38 ` Maciej W. Rozycki
2002-06-24 11:45 ` Ralf Baechle
2002-06-24 14:49 ` Maciej W. Rozycki
2002-06-24 12:02 ` Kevin D. Kissell
2002-06-24 12:02 ` Kevin D. Kissell
2002-06-24 12:04 ` Ralf Baechle
2002-06-24 12:02 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020624115452.A25138@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=carstenl@mips.com \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.