All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: linuxppc-dev@lists.linuxppc.org, Paul Mackerras <paulus@samba.org>
Subject: [PATCH/RFC] Change how we pick which _kd_mksound to use.
Date: Mon, 1 Jul 2002 08:27:27 -0700	[thread overview]
Message-ID: <20020701152727.GC20920@opus.bloom.county> (raw)


The following changes how we pick a _kd_mksound.  The problem is that on
some machines, such as IBM405, the default _kd_mksound breaks horribly
due to the inb/outb's attempting to fiddle with timers which don't
exist.  This changes the test which selects either an empty _kd_mksound
or the one in question from __powerpc__ to CONFIG_PPC64 (since from what I
understand, __powerpc__ is defined on ppc64) || (CONFIG_PPC32 &&
CONFIG_6xx).  The CONFIG_6xx test is because these boards are the ones
which tend to have a SuperIO chip, or something else with the timers at
0x61, 0xB6, etc.

The other option would be to define an empty no_kd_mksound or so on
4xx/8xx and then conditionally set kd_mksound to that, but I would
prefer this since we're already doing some preprocessor checks anyhow.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

===== drivers/char/vt.c 1.9 vs edited =====
--- 1.9/drivers/char/vt.c	Tue Feb  5 00:55:25 2002
+++ edited/drivers/char/vt.c	Mon Jul  1 08:05:43 2002
@@ -90,7 +90,8 @@
  * comments - KDMKTONE doesn't put the process to sleep.
  */

-#if defined(__i386__) || defined(__alpha__) || defined(__powerpc__) \
+#if defined(__i386__) || defined(__alpha__) || defined(CONFIG_PPC64) \
+    || (defined(CONFIG_PPC32) && defined(CONFIG_6xx)) \
     || (defined(__mips__) && defined(CONFIG_ISA)) \
     || (defined(__arm__) && defined(CONFIG_HOST_FOOTBRIDGE)) \
     || defined(__x86_64__)

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

             reply	other threads:[~2002-07-01 15:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-01 15:27 Tom Rini [this message]
2002-07-07  1:32 ` [PATCH/RFC] Change how we pick which _kd_mksound to use Paul Mackerras
2002-07-08 14:46   ` Tom Rini
2002-07-08 16:07   ` Armin
2002-07-08 16:11     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020701152727.GC20920@opus.bloom.county \
    --to=trini@kernel.crashing.org \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.