From: Vojtech Pavlik <vojtech@suse.cz>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
Martin Dalecki <dalecki@evision-ventures.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.24 IDE 97
Date: Thu, 4 Jul 2002 16:18:09 +0200 [thread overview]
Message-ID: <20020704161809.A27207@ucw.cz> (raw)
In-Reply-To: <20020704142938.D11601@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Thu, Jul 04, 2002 at 02:29:38PM +0100
On Thu, Jul 04, 2002 at 02:29:38PM +0100, Russell King wrote:
> On Wed, Jul 03, 2002 at 12:22:11AM +0200, Bartlomiej Zolnierkiewicz wrote:
> > This patch is a accumulation of ata-hosts-7/8/9/10/11, ata-autodma
> > and ata-ata66_check patches previously posted on LKML.
>
> >From a first review only, it looks like this patch prevents the chipset
> drivers from disabling DMA mode on initialisation. This is Really Bad(tm)
> since some revisions of some chipsets must _never_ be placed into DMA
> mode due to hardware bugs. Even if the user selects CONFIG_IDEDMA_AUTO.
>
> The code in sl82c105.c knows about the chipset revisions that this is
> required for, and it looks like the code in ide-pci.c will override the
> chipset if CONFIG_IDEDMA_AUTO is enabled.
I think the best solution (for now) probably would be to supply the mode
map to the core IDE driver so that it can choose which modes (and
whether DMA) are available.
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2002-07-04 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-02 22:22 [PATCH] 2.5.24 IDE 97 Bartlomiej Zolnierkiewicz
2002-07-04 13:29 ` Russell King
2002-07-04 14:18 ` Vojtech Pavlik [this message]
2002-07-04 14:33 ` Russell King
2002-07-04 17:44 ` Bartlomiej Zolnierkiewicz
2002-07-04 17:51 ` Benjamin Herrenschmidt
2002-07-04 21:55 ` Bartlomiej Zolnierkiewicz
2002-07-04 17:40 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020704161809.A27207@ucw.cz \
--to=vojtech@suse.cz \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.