From: Jens Axboe <axboe@kernel.org>
To: Jochen Suckfuell <jo-lkml@suckfuell.net>
Cc: Thunder from the hill <thunder@ngforever.de>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Bill Davidsen <davidsen@tmr.com>,
Andries Brouwer <aebr@win.tue.nl>, Adrian Bunk <bunk@fs.tum.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Re: Disk IO statistics still buggy
Date: Fri, 12 Jul 2002 07:46:32 +0200 [thread overview]
Message-ID: <20020712054632.GN855@suse.de> (raw)
In-Reply-To: <20020709190019.A19394@ds217-115-141-141.dedicated.hosteurope.de>
On Tue, Jul 09 2002, Jochen Suckfuell wrote:
> --- linux/drivers/scsi/scsi_lib.c Mon Jul 8 16:15:27 2002
> +++ linux_work/drivers/scsi/scsi_lib.c Tue Jul 9 17:56:39 2002
> @@ -426,7 +426,9 @@
> if (req->waiting != NULL) {
> complete(req->waiting);
> }
> + spin_lock_irq(&io_request_lock);
> req_finished_io(req);
> + spin_unlock_irq(&io_request_lock);
> add_blkdev_randomness(MAJOR(req->rq_dev));
>
> SDpnt = SCpnt->device;
good spotting, that's definitely a bug
--
Jens Axboe
next prev parent reply other threads:[~2002-07-12 5:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-04 11:52 Disk IO statistics still buggy Jochen Suckfuell
2002-07-04 11:59 ` Jochen Suckfuell
2002-07-04 18:31 ` Adrian Bunk
2002-07-06 4:15 ` Bill Davidsen
2002-07-06 7:48 ` Andries Brouwer
2002-07-06 13:42 ` Thunder from the hill
2002-07-09 17:00 ` [PATCH] " Jochen Suckfuell
2002-07-11 21:27 ` Marcelo Tosatti
2002-07-22 15:11 ` Jochen Suckfuell
2002-07-12 5:46 ` Jens Axboe [this message]
2002-07-12 5:59 ` no msg when linux-kernel boot louie miranda
2002-07-12 10:57 ` Tigran Aivazian
2002-07-12 13:16 ` szonyi calin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020712054632.GN855@suse.de \
--to=axboe@kernel.org \
--cc=aebr@win.tue.nl \
--cc=bunk@fs.tum.de \
--cc=davidsen@tmr.com \
--cc=jo-lkml@suckfuell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=thunder@ngforever.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.