From: Greg KH <greg@kroah.com>
To: Craig Kulesa <ckulesa@as.arizona.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [USB] uhci-hcd oops on APM resume (2.5.23-26)
Date: Fri, 19 Jul 2002 12:43:26 -0700 [thread overview]
Message-ID: <20020719194326.GA23137@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0207182241510.4647-100000@loke.as.arizona.edu>
On Thu, Jul 18, 2002 at 11:28:23PM -0700, Craig Kulesa wrote:
>
>
> Looks fine. Works great! Upon the first APM suspend:
Hm, does this patch from Jan Harkes solve the uhci-hcd resume problem
for you?
thanks,
greg k-h
--- linux-2.5.24.orig/drivers/usb/host/uhci-hcd.c Fri Jun 21 14:56:12 2002
+++ linux-2.5.24/drivers/usb/host/uhci-hcd.c Sun Jul 7 01:18:44 2002
@@ -2074,6 +2074,8 @@
/* Run and mark it configured with a 64-byte max packet */
outw(USBCMD_RS | USBCMD_CF | USBCMD_MAXP, io_addr + USBCMD);
+
+ uhci->hcd.state = USB_STATE_READY;
}
#ifdef CONFIG_PROC_FS
@@ -2364,8 +2366,6 @@
/* disable legacy emulation */
pci_write_config_word(dev, USBLEGSUP, USBLEGSUP_DEFAULT);
-
- hcd->state = USB_STATE_READY;
usb_connect(uhci->rh_dev);
uhci->rh_dev->speed = USB_SPEED_FULL;
next prev parent reply other threads:[~2002-07-19 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-19 6:28 [USB] uhci-hcd oops on APM resume (2.5.23-26) Craig Kulesa
2002-07-19 19:43 ` Greg KH [this message]
2002-07-20 6:18 ` Craig Kulesa
2002-07-20 18:36 ` Johannes Erdfelt
2002-07-20 19:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020719194326.GA23137@kroah.com \
--to=greg@kroah.com \
--cc=ckulesa@as.arizona.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.