From: Ralf Baechle <ralf@oss.sgi.com>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Carsten Langgaard <carstenl@mips.com>, linux-mips@oss.sgi.com
Subject: Re: sys32_execve fix
Date: Mon, 22 Jul 2002 20:36:18 +0200 [thread overview]
Message-ID: <20020722203618.A22721@dea.linux-mips.net> (raw)
In-Reply-To: <Pine.GSO.3.96.1020722184609.2373J-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Mon, Jul 22, 2002 at 06:56:42PM +0200
On Mon, Jul 22, 2002 at 06:56:42PM +0200, Maciej W. Rozycki wrote:
> > The problem is that "nargs" in arch/mips64/kernel/linux32.c fails when
> > argv is NULL, the patch below should fix the problem:
>
> How about just:
>
> if (!arg)
> return 0;
>
> at the top? Gcc should optimize it to a single branch, likely not taken,
> and a register move.
Right. Coincidentally this is also what was done to the IA64 port where
this code did originate.
Ralf
prev parent reply other threads:[~2002-07-22 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-22 13:52 sys32_execve fix Carsten Langgaard
2002-07-22 14:46 ` Carsten Langgaard
2002-07-23 9:19 ` Carsten Langgaard
2002-07-23 11:39 ` Ralf Baechle
2002-07-22 16:56 ` Maciej W. Rozycki
2002-07-22 18:36 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020722203618.A22721@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=carstenl@mips.com \
--cc=linux-mips@oss.sgi.com \
--cc=macro@ds2.pg.gda.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.