From: Erik Andersen <andersen@codepoet.org>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] compile fix for Linux 2.4.19-rc3-ac2
Date: Mon, 22 Jul 2002 22:37:24 -0600 [thread overview]
Message-ID: <20020723043724.GA12088@codepoet.org> (raw)
In-Reply-To: <200207230022.g6N0Mgh30698@devserv.devel.redhat.com>
On Mon Jul 22, 2002 at 08:22:42PM -0400, Alan Cox wrote:
> o AMD native powermanagement (Tony Lindgren,
> Johnathan Hicks)
> | Replaces amd768_pm as its already far better
Doesn't compile:
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -Os -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -nostdinc -I /usr/lib/gcc-lib/i386-linux/2.95.4/include -DKBUILD_BASENAME=amd76x_pm -c -o amd76x_pm.o amd76x_pm.c
amd76x_pm.c: In function `sb_idle_amd_766':
amd76x_pm.c:137: warning: unused variable `regshort'
amd76x_pm.c: In function `amd_idle_main':
amd76x_pm.c:360: `pm_idle' undeclared (first use in this function)
amd76x_pm.c:360: (Each undeclared identifier is reported only once
amd76x_pm.c:360: for each function it appears in.)
amd76x_pm.c: In function `amd_idle_cleanup':
amd76x_pm.c:377: `pm_idle' undeclared (first use in this function)
make[3]: *** [amd76x_pm.o] Error 1
make[3]: Leaving directory `/usr/src/linux/drivers/char'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/usr/src/linux/drivers/char'
make[1]: *** [_subdir_char] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [_dir_drivers] Error 2
This trivial patch fixes it:
--- drivers/char/amd76x_pm.c.orig Mon Jul 22 22:32:55 2002
+++ drivers/char/amd76x_pm.c Mon Jul 22 22:34:49 2002
@@ -35,6 +35,7 @@
#include <linux/slab.h>
#include <linux/pci.h>
#include <linux/delay.h>
+#include <linux/pm.h>
#include "amd76x_pm.h"
@@ -134,7 +135,6 @@
sb_idle_amd_766(int enable)
{
unsigned int regdword;
- unsigned short regshort;
unsigned char regbyte;
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
next prev parent reply other threads:[~2002-07-23 4:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-23 0:22 Linux 2.4.19-rc3-ac2 Alan Cox
2002-07-23 4:37 ` Erik Andersen [this message]
2002-07-23 6:57 ` Christoph Hellwig
2002-07-23 7:34 ` Adrian Bunk
2002-07-23 7:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020723043724.GA12088@codepoet.org \
--to=andersen@codepoet.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.