All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@suse.de>
To: Christopher Hoover <ch@hpl.hp.com>
Cc: linux-kernel@vger.kernel.org, ch@murgatroid.com
Subject: Re: [PATCH] 2.5.24+ fix needed for non-modular video build
Date: Tue, 23 Jul 2002 14:37:44 +0200	[thread overview]
Message-ID: <20020723143744.C14323@suse.de> (raw)
In-Reply-To: <20020722134514.B11556@friction.hpl.hp.com>; from ch@hpl.hp.com on Mon, Jul 22, 2002 at 01:45:14PM -0700

On Mon, Jul 22, 2002 at 01:45:14PM -0700, Christopher Hoover wrote:

 > -#ifdef MODULE
 > -#if defined(CONFIG_PROC_FS) && defined(CONFIG_VIDEO_PROC_FS)
 >  static void videodev_proc_destroy(void)
 >  {
 >  	if (video_dev_proc_entry != NULL)
 > @@ -298,8 +296,6 @@
 >  	if (video_proc_entry != NULL)
 >  		remove_proc_entry("video", &proc_root);
 >  }
 > -#endif
 > -#endif

Why are you removing the inner ifdef too ? This looks like it
makes sense (to me at least)

        Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

  reply	other threads:[~2002-07-23 12:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-22 20:45 [PATCH] 2.5.24+ fix needed for non-modular video build Christopher Hoover
2002-07-23 12:37 ` Dave Jones [this message]
2002-07-23 17:18   ` Christopher Hoover

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020723143744.C14323@suse.de \
    --to=davej@suse.de \
    --cc=ch@hpl.hp.com \
    --cc=ch@murgatroid.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.