Re: [cset] Add the EVIOCSABS ioctl for X people.

[Vojtech Pavlik <vojtech@suse.cz>]

On Sun, Jul 28, 2002 at 05:32:53PM +1000, Brad Hards wrote:

> On Fri, 26 Jul 2002 01:08, Vojtech Pavlik wrote:
> > On Fri, Jul 26, 2002 at 12:47:20AM +1000, Brad Hards wrote:
> > No problem. Send me a patch that does it for both the EVIOSGABS and
> > EVIOCSABS and I'll take it. You can either just do it in evdev.c, or
> > change every driver to use the struct.
> I am just doing the evdev.c (ie the ABI) at this stage. I may look at the
> internal representation later.
> Patch against 2.5.29. Looks OK?

Yes.

> > > I could live with curr, min and max instead of *_value, but it
> > > would be nicer if it was a bit more descriptive.
> >
> > You can make it current, minimum, and maximum, if you wish.  I'm a
> > minimalist when it comes to naming, and I don't really think "_value" is
> > bringing much information here. All of them are values after all.
> "current" is a bad idea. I used curr_value.

How about just "value" then?

> Also, it is nice if you can retain the attributions (so I can get some
> ego satisfaction, and so people know who to blame). This is generally
> done by maintainers - any chance you can do this too?

I'm stil fighting with BK to use something else than my e-mail address
in the changesets. So far I've always put the author of the patch into
the BK comment at least, but still haven't found how to change the cset
author.

If you find out, please tell me. Or anybody else.

Thanks.

-- 
Vojtech Pavlik
SuSE Labs