From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] vmap_pages() (4th resend)
Date: Mon, 29 Jul 2002 21:46:38 +0200 [thread overview]
Message-ID: <20020729214638.A4582@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.33.0207291222440.11377-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Mon, Jul 29, 2002 at 12:25:24PM -0700
On Mon, Jul 29, 2002 at 12:25:24PM -0700, Linus Torvalds wrote:
> > The old vmalloc_area_pages is renamed to __vmap_area_pages and
> > vmalloc_area_pages is a small wrapper around it, passing in an NULL page
> > array. Similarly __vmalloc is renamed to vmap_pages and a small wrapper
> > is added.
>
> I don't like the NULL page array.
>
> I think vmalloc() should just allocate the pages and create the page
> array, and vmap_pages() should never check for NULL. Ok?
I looked into implementing your suggestion the last, but the problem is
that we need to pass in a page array. To do so we could either allocate
all the pages as high-order allocation or kmalloc() the array where we
place the pages. Both doesn't seem very practical to me..
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-07-29 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-29 19:15 [PATCH] vmap_pages() (4th resend) Christoph Hellwig
2002-07-29 19:25 ` Linus Torvalds
2002-07-29 19:46 ` Christoph Hellwig [this message]
2002-07-29 20:59 ` Linus Torvalds
2002-07-29 21:29 ` Christoph Hellwig
2002-08-05 17:42 ` Christoph Hellwig
2002-08-05 18:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020729214638.A4582@lst.de \
--to=hch@lst.de \
--cc=linux-mm@kvack.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.