From: Carlos O'Donell <carlos@baldric.uwo.ca>
To: Joel Soete <joel.soete@freebel.net>
Cc: bame@fc.hp.com, parisc-linux@parisc-linux.org
Subject: Re: [parisc-linux] Palo: cmdline and commanline has different limits?
Date: Sun, 4 Aug 2002 18:36:18 -0400 [thread overview]
Message-ID: <20020804223618.GG19482@systemhalted> (raw)
In-Reply-To: <3D4D7AF8.9030005@freebel.net>
> Hi Paul,
> I just notice a small problem:
> In palo/palo/palo.c at line 720:
> ...
> if (strlen(commandline) > 255)
> ...
> OTC in palo/lib/common.h in struct firstblock at line 46:
> char cmdline[128]; /* Up to 127 bytes of text plus a \0 */
> unsigned char pad1[0xf0 - 8 - 7 * sizeof (int) - 128];
>
> I do not know yet if pad1 can be removed so that cmdline could reach 204
> [240-8-7*(sizeof int = 4?)] char lenght, also I prefer to let you choise.
>
> Joel
I don't see why not? Would 200 characters be enough for your application?
I do think that "> 255" should be changed in palo.c
To push it out further would require teaching palo about
both formats (and understanding why the comment mentions
that all the data must fit in 256 byes).
c.
next prev parent reply other threads:[~2002-08-04 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-04 19:05 [parisc-linux] Palo: cmdline and commanline has different limits? Joel Soete
2002-08-04 22:36 ` Carlos O'Donell [this message]
2002-08-05 14:59 ` Carlos O'Donell
2002-08-07 6:30 ` jsoe0708
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020804223618.GG19482@systemhalted \
--to=carlos@baldric.uwo.ca \
--cc=bame@fc.hp.com \
--cc=joel.soete@freebel.net \
--cc=parisc-linux@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.