All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vamsi Krishna S ." <vamsi@in.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	"David S. Miller" <davem@redhat.com>,
	linux-kernel@vger.kernel.org, vamsi_krishna@in.ibm.com
Subject: Re: [PATCH] kprobes for 2.5.30
Date: Wed, 7 Aug 2002 10:29:49 +0530	[thread overview]
Message-ID: <20020807102949.A23745@in.ibm.com> (raw)
In-Reply-To: <20020807020259.70602418A@lists.samba.org>; from rusty@rustcorp.com.au on Wed, Aug 07, 2002 at 10:55:04AM +1000

Hi Rusty,

On Wed, Aug 07, 2002 at 10:55:04AM +1000, Rusty Russell wrote:
> In message <20020806164242.B22164@in.ibm.com> you write:
> > - move trap1 and trap3 interrupt gates only under CONFIG_KPROBES. Please
> >   note that if we don't do this, we need to call restore_interrupts()
> >   from the dummy (post_)kprobe_handler() in include/asm-i386/kprobes.h
> >   when CONFIG_KPROBES is off. I didn't like this subtle side effect. hence
> >   the #ifdef CONFIG_KPROBES around _set_trap_gate. Still, the calling 
> >   conventions of do_debug and do_int3 remain independent of CONFIG_KPROBES.
> 
> Hmm, I thought about this but then decided against it.  Your way is
> pretty subtle too: I think I prefer the restore_interrupts()
> explicitly after the (failed) call to kprobe_handler, ie (on top of
> your patch, which looks excellent):

I agree this one is even better. 

Thanks,
Vamsi.

> <snip patch>

-- 
Vamsi Krishna S.
Linux Technology Center,
IBM Software Lab, Bangalore.
Ph: +91 80 5044959
Internet: vamsi@in.ibm.com

  reply	other threads:[~2002-08-07  4:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-02  2:11 [PATCH] kprobes for 2.5.30 Rusty Russell
2002-08-02  2:14 ` David S. Miller
2002-08-02 14:00   ` Vamsi Krishna S .
2002-08-05  4:14   ` Rusty Russell
2002-08-05  4:24     ` Linus Torvalds
2002-08-05  6:37       ` Rusty Russell
2002-08-05 16:10         ` Linus Torvalds
2002-08-06  2:18           ` Rusty Russell
2002-08-06  5:48             ` Linus Torvalds
2002-08-06  7:22               ` Rusty Russell
2002-08-06  7:59                 ` Christoph Hellwig
2002-08-06 10:59                   ` Vamsi Krishna S .
2002-08-06 11:12                 ` Vamsi Krishna S .
2002-08-07  0:55                   ` Rusty Russell
2002-08-07  4:59                     ` Vamsi Krishna S . [this message]
2002-08-06 16:35                 ` Linus Torvalds
2002-08-05  5:34     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020807102949.A23745@in.ibm.com \
    --to=vamsi@in.ibm.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@transmeta.com \
    --cc=vamsi_krishna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.